Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): make expose of non-generic template ref required #4795

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

zhiyuanzmj
Copy link
Collaborator

Should be required when is not a generic component.
image

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4795

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4795

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4795

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4795

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4795

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4795

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4795

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4795

commit: a6eaf97

@KazariEX KazariEX changed the title fix(language-core): correct type for template-ref fix(language-core): make expose of non-generic component required Sep 3, 2024
@KazariEX KazariEX changed the title fix(language-core): make expose of non-generic component required fix(language-core): make expose of non-generic template ref required Sep 3, 2024
@johnsoncodehk
Copy link
Member

Can you add a test case?

@zhiyuanzmj
Copy link
Collaborator Author

Can you add a test case?

It can correct infer type, Only affecting twoslash.
Such as this:
image

@johnsoncodehk
Copy link
Member

I see, thanks!

@johnsoncodehk johnsoncodehk merged commit 858d7c4 into master Sep 4, 2024
9 checks passed
@johnsoncodehk johnsoncodehk deleted the fix/template-ref-required branch September 4, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants