-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language-service): better sorting & filtering of completion #4671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsoncodehk
changed the title
fix(language-service): drop unnecessary completion of event
refactor(language-service): drop unnecessary completion of event
Aug 9, 2024
johnsoncodehk
changed the title
refactor(language-service): drop unnecessary completion of event
fix(language-service): drop unnecessary completion of event
Aug 9, 2024
@KazariEX Could you add a minimal test case? |
KazariEX
changed the title
fix(language-service): drop unnecessary completion of event
fix(language-service): better sorting & filtering of completion
Aug 9, 2024
KazariEX
changed the title
fix(language-service): better sorting & filtering of completion
feat(language-service): better sorting & filtering of completion
Aug 9, 2024
I have revised this PR and now it will do the following in the completion:
|
commit: vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
|
I'm a bit unsure of the best way to display for DX so show all items if possible, glad you have insights on this. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4670