Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update packages to support ESlint v6 #979

Merged
merged 3 commits into from
Nov 6, 2019

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik commented Nov 6, 2019

This PR addresses: #920

It:

  • bumps few packages to ensure Eslint v6 compatibility
  • updates required Node.js version, as in ESLint v6 support for Node.js@6 has been dropped
  • removes ESLint v5 compatibility build from our CircleCI config

It looks however we might still need to get vue-eslint-parser updated, as its current peerDependencies list include only ESLint ^5.0.0 - cc @mysticatea

@michalsnik michalsnik self-assigned this Nov 6, 2019
@michalsnik michalsnik merged commit 6d48d11 into master Nov 6, 2019
@michalsnik michalsnik deleted the chore/update-packages-to-support-eslint-6 branch November 6, 2019 15:58
@@ -40,7 +40,7 @@
"url": "https://github.com/vuejs/eslint-plugin-vue/issues"
},
"engines": {
"node": ">=6.5"
"node": ">=8.10"
},
"peerDependencies": {
"eslint": "^5.0.0 || ^6.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can chanege ^6.0.0 ?

scq pushed a commit to totara/eslint-plugin-vue that referenced this pull request Jun 22, 2022
* Update packages to support ESlint 6

* Update Node.js requirement to 8.10 and above

* Remove Eslint@5 compatibility check from CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants