Fix: no-boolean-default with 'default-false' on boolean props with unset default #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rule
no-boolean-default
breaks when used with option'default-false'
on a boolean prop that does not havedefault
property, with exception:This PR adds tests that expose the issue (simply the same cases but applied without options and with each option where applicable) and a check for a falsy value returned from
getDefaultNode(propDef)
.Also, changed the error message for
'default-false'
option a bit, as "Boolean prop should be defaulted to false." may mean that it "should be defaulted", while the logic is "can be defaulted or not, but if it is, it must only be false".