-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Vue APIs from auto imports #2422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
changed the title
wip: support
featsupport Mar 11, 2024
detectAutoImport
optiondetectAutoImport
option
antfu
changed the title
featsupport
feat: support Vue APIs from auto imports
Mar 11, 2024
detectAutoImport
option
This was referenced Mar 11, 2024
FloEdelmann
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side, apart from one small docs change. Thanks for contributing!
Co-authored-by: Flo Edelmann <[email protected]>
FloEdelmann
approved these changes
Mar 11, 2024
ota-meshi
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes rules able to recognize global
ref
computed
variables, when they are presented in theglobals
option in ESLint.This would require presets to be configured properly, for Nuxt I will configure https://github.com/antfu/nuxt-module-eslint-config and for the rest I will update my eslint config: https://github.com/antfu/eslint-config
fix #1969