-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint-plugin-unicorn to v47 #2146
Update eslint-plugin-unicorn to v47 #2146
Conversation
It seems to have another problem of eslint-plugin-vue and ESLint. If ESLint v8.40 is installed, eslint-plugin-vue’s tests failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the dependency update and lint fixes! However, I'm not sure if they are all compatible with the Node versions we support. @ota-meshi which Node versions should we support? If some of the newer language features (importing builtin Node modules via the node:
prefix; array .at()
function; string .replaceAll()
function) are not available in all supported Node versions, we should rather disable the respective lint rules.
Also, I'm not sure what causes the other failing tests.
Thank you for this PR. |
I turned off some rules
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related issues: nothing
currently, main branch of eslint-plugin-vue cannot run lint.
Due to a bug in eslint-plugin-unicorn, if eslint-plugin-vue installs ESLint v42.0, eslint-plugin-unicorn must be v46.0.1 or higher.
ref: sindresorhus/eslint-plugin-unicorn#2076
What I did
fix lint errorturn off rulesHow to fix lint error254 problems (253 errors, 1 warning)
npm run lint:fix
=>4 problems (3 errors, 1 warning)
1 problem (0 errors, 1 warning)