Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move component basics section #39

Merged
merged 22 commits into from
Jan 28, 2020
Merged

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented Jan 22, 2020

Please when reviewing pay attention to v-model part: I was trying to check it thoroughly but it's always better to have more pairs of eyes on it

@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Jan 22, 2020
@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request labels Jan 22, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this Jan 22, 2020
src/guide/component-basics.md Outdated Show resolved Hide resolved
src/guide/component-basics.md Outdated Show resolved Hide resolved
src/guide/component-basics.md Outdated Show resolved Hide resolved
@NataliaTepluhina
Copy link
Member Author

@znck changed back to camelCased names after the issue fix. The only kebab-cased thing is a :model-value prop due to our styleguide

Could you please give it the last (I hope so!) look?

src/guide/component-basics.md Outdated Show resolved Hide resolved
src/guide/component-basics.md Outdated Show resolved Hide resolved
src/guide/component-basics.md Show resolved Hide resolved
@NataliaTepluhina
Copy link
Member Author

@znck added an explanation of case-insensitiveness and using kebab-cased names

@NataliaTepluhina NataliaTepluhina requested a review from znck January 28, 2020 17:14
@NataliaTepluhina NataliaTepluhina merged commit 94e1724 into master Jan 28, 2020
@NataliaTepluhina NataliaTepluhina deleted the move-component-basics branch May 4, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants