Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group assets in duplicate paths between root and public by relativePath #514

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

LoTwT
Copy link
Contributor

@LoTwT LoTwT commented Jul 9, 2024

description

This PR is to close #510.

Todolist

  • add relativePath in AssetInfo
  • grid view
  • list view

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 7279b66
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/668e582d6cdaa00008cc5ccd

@LoTwT LoTwT reopened this Jul 9, 2024
@LoTwT LoTwT marked this pull request as ready for review July 9, 2024 07:43
@alexzhang1030
Copy link
Member

alexzhang1030 commented Jul 9, 2024

https://vitejs.dev/config/shared-options.html#publicdir

Could you read the publicDir config to make it more robust?

@LoTwT
Copy link
Contributor Author

LoTwT commented Jul 9, 2024

https://vitejs.dev/config/shared-options.html#publicdir

Could you read the publicDir config to make it more robust?

Thank you for your advice. I will check it and optimize it later.

@alexzhang1030
Copy link
Member

Can you provide a screenshot?

@LoTwT
Copy link
Contributor Author

LoTwT commented Jul 16, 2024

steps

  • nr dev
  • nr play
iShot_2024-07-16_16.22.54.mp4

assets in root

image

assets in public

image

vite.svg

image

@webfansplz webfansplz merged commit 12614a9 into vuejs:main Jul 17, 2024
5 checks passed
@LoTwT LoTwT deleted the asset-path branch July 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assets in duplicate paths between root and public will be divided into the same path in the assets tab
3 participants