Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): use Ic icon on custom inspector/tab/command #466

Merged
merged 27 commits into from
Jun 28, 2024
Merged

Conversation

webfansplz
Copy link
Member

@webfansplz webfansplz commented Jun 23, 2024

Close #472

@webfansplz webfansplz marked this pull request as draft June 23, 2024 09:58
Copy link

netlify bot commented Jun 23, 2024

Deploy Preview for vue-devtools-docs ready!

Name Link
🔨 Latest commit 5eba143
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/667e3f3e25740700082b2e71
😎 Deploy Preview https://deploy-preview-466--vue-devtools-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alexzhang1030
Copy link
Member

alexzhang1030 commented Jun 24, 2024

How about aligning with the behavior of @unocss/preset-icons? With background-image, we can easily use font-size and color to configure its width/height and fill.

image

@reslear
Copy link
Contributor

reslear commented Jun 24, 2024

And why does this happen, is it because of treeshaking or should it be like this for offline first ?

@alexzhang1030
Copy link
Member

And why does this happen, is it because of treeshaking or should it be like this for offline first ?

To comply with Chromium Manifest V3 requirements, we bundled all the ic icons(for legacy devtools plugin api) together instead of loading them online. Manifest V3 does not support loading external resources.

@reslear
Copy link
Contributor

reslear commented Jun 24, 2024

ahhh got it. you should have specified that the icon pack names are like: devtools-legacy :)

@alexzhang1030 alexzhang1030 marked this pull request as ready for review June 25, 2024 08:06
@alexzhang1030
Copy link
Member

alexzhang1030 commented Jun 25, 2024

@webfansplz updated to using backgroungImage, can you review it? Thanks

@alexzhang1030 alexzhang1030 changed the title feat(ui): ic-icon component feat(client): use Ic icon on custom inspector/tab Jun 27, 2024
@alexzhang1030 alexzhang1030 changed the title feat(client): use Ic icon on custom inspector/tab feat(client): use Ic icon on custom inspector/tab/command Jun 27, 2024
@webfansplz webfansplz merged commit bc97b34 into main Jun 28, 2024
5 checks passed
@webfansplz webfansplz deleted the feat-ui branch June 28, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vuex icon missing
3 participants