Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): sync state between separate window with floating panel #459

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Jun 19, 2024

should close #458, need test by @sxcooler, test on my local works properly.

Reproduction step:

  1. open the page with the devtools floating panel
  2. open a separate window
  3. update settings on floating panel
  4. go to the separate window, and storage is changed, but UI is not changed.

Copy link

netlify bot commented Jun 19, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 149ca28
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/66724cac54676b00085995ec

@sxcooler
Copy link

should close #458, need test by @sxcooler, test on my local works properly.

Reproduction step:

  1. open the page with the devtools floating panel
  2. open a separate window
  3. update settings on floating panel
  4. go to the separate window, and storage is changed, but UI is not changed.

Sorry, but how can I take part in testing?

@alexzhang1030
Copy link
Member Author

alexzhang1030 commented Jun 19, 2024

1. clone source

You can use gh CLI

image

Or clone my repo and switch to fix/client branch.

2. build

pnpm i
pnpm build

3. link to your project

If you are using pnpm

// package.json
{
  "dependency": {
    //                                        <your-path-to-vite-package>
    "vite-plugin-vue-devtools": "../../../vue-devtools-next/packages/vite"
  }
}

@sxcooler
Copy link

sxcooler commented Jun 19, 2024

1. clone source

You can use gh CLI

谢谢指导,pnpm build的时候遇到以下两个错误:

image

以及

image

但我检查package/electron/dist目录,devtools.d.ts这个文件存在:

image

如果强行把这个vite链接到我的项目,会出现devtools无法打开:

image

一直停留在加载动画。

我npmrc和pnpm config都已经加上了electron等的mirror
尝试过pnpm store prune无法解决

我看你代码改动比较简单,原理上也说得通,你如果测试没有问题我可以先把原issue关闭。

@alexzhang1030
Copy link
Member Author

1. clone source

You can use gh CLI

谢谢指导,pnpm build的时候遇到以下两个错误:

image

以及

image

但我检查package/electron/dist目录,devtools.d.ts这个文件存在:

image

如果强行把这个vite链接到我的项目,会出现devtools无法打开:

image

一直停留在加载动画。

我npmrc和pnpm config都已经加上了electron等的mirror 尝试过pnpm store prune无法解决

我看你代码改动比较简单,原理上也说得通,你如果测试没有问题我可以先把原issue关闭。

😂, 可以等到 merge 了,这个 build error 的问题后面会追踪一下

@webfansplz webfansplz changed the title fix(client): state sync between seperate window with floating panel issue fix(client): sync state between separate window with floating panel Jun 19, 2024
@webfansplz webfansplz merged commit 3daaf00 into vuejs:main Jun 19, 2024
5 checks passed
@alexzhang1030 alexzhang1030 deleted the fix/client branch June 19, 2024 13:47
@atilkan
Copy link

atilkan commented Jul 22, 2024

This comes with another issue.

  • From separate window
  • Click select component button (Attachment 1)
  • Select a component in the page
  • Floating panel appears, it should not based on my settings (Always hide),
  • And it doesn't disappear without clicking somewhere else, causing you to lose the selected component scope.
Screenshot 2024-07-22 at 17 30 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seperate window cannot sync state with floating panel
4 participants