Changing to @vue/eslint-config-typescript by default causes issues
#158
Comments
robertstewart89
added a commit
to robertstewart89/Eslint-config-develeop-laravel
that referenced
this issue
Sep 24, 2022
Fixes vuejs/eslint-config-typescript#14 Fixes vuejs/create-vue#158 Technically turning new rules on would be a breaking change because it introduces more errors in an existing codebase. However, in our README we've already made it clear that this ruleset should only be used with `@vue/cli` or `create-vue`, so an existing `eslint:recommended` config is expected, thus no breaking changes. Nevertheless, I choose to make it `warn` instead of `error` to minimize the impact.
goldentroll
added a commit
to goldentroll/eslint-config-typescript
that referenced
this issue
Mar 14, 2023
Fixes vuejs/eslint-config-typescript#14 Fixes vuejs/create-vue#158 Technically turning new rules on would be a breaking change because it introduces more errors in an existing codebase. However, in our README we've already made it clear that this ruleset should only be used with `@vue/cli` or `create-vue`, so an existing `eslint:recommended` config is expected, thus no breaking changes. Nevertheless, I choose to make it `warn` instead of `error` to minimize the impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In particular, we are hitting vuejs/eslint-config-typescript#14 around usage of
defineEmits<{(e: 'foo', value: string): void}>(), and in general just less useful rules enabled which otherwise proved quite useful to have in a Vue project. I don't think this is such a good change IMHO.See: f4ac339#commitcomment-83124443
The text was updated successfully, but these errors were encountered: