fix(runtime-core): v-model modifiers trim and number when cases don't match #9609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
…hyphenate string in props and camelize in emits
yyx990803
force-pushed
the
v-model-modifier-case
branch
from
92de07a to
03af42c
Compare
jacobfogolyan
pushed a commit
to jacobfogolyan/vuejs-core
that referenced
this pull request
Jul 13, 2024
…don't match (vuejs#9609) close vuejs#4848 close vuejs#4850 (based on commits from vuejs#4850) Co-authored-by: zhaozhongyu <[email protected]> Co-authored-by: Evan You <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4848.
There is an existing PR for this, #4850. This PR includes the commits from that PR, but I thought there was another edge case that needed addressing, otherwise it would cause a regression.
The original PR assumed that the prop would always be written in either kebab-case or camelCase. While this is usually true, it doesn't take account of the possibility that the prop name could be written in neither case convention. In that scenario, an exact match should still work, which is what I've tried to handle here.
I've also switched the new tests from
jesttoviand added some extra tests.