Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): TransitionGroup children el may be null #9068

Closed
wants to merge 5 commits into from

Conversation

royalknight56
Copy link
Contributor

@royalknight56 royalknight56 commented Aug 29, 2023

close: #9067
When the children of TransitionGroup are components, first set the elements inside the component to empty through v-if. Afterwards, an error will be reported when TransitionGroup executes the end animation.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case for the issue?

@royalknight56
Copy link
Contributor Author

Could you add a test case for the issue?

done

@github-actions
Copy link

github-actions bot commented Aug 31, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+49 B) 32.7 kB (+15 B) 29.5 kB (+30 B)
vue.global.prod.js 132 kB (+49 B) 49.3 kB (+10 B) 44.3 kB (-10 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@sxzz sxzz added ready for review This PR requires more reviews and removed wait changes labels Aug 31, 2023
@haoqunjiang haoqunjiang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Oct 24, 2023
@edison1105
Copy link
Member

edison1105 commented Oct 24, 2023

This PR doesn't seem like the right solution. see #9421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

TransitionGroup children el may be null
4 participants