Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): cssvars correctly handles async components #8523

Merged
merged 10 commits into from
Apr 15, 2024
Merged

fix(runtime-dom): cssvars correctly handles async components #8523

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1e3c230
fix(runtime-dom): cssvars correctly handles async components
baiwusanyu-c Jun 8, 2023
bb0f934
fix(runtime-core): updated code
baiwusanyu-c Jun 8, 2023
b0dfab8
fix(runtime-core): added unit test
baiwusanyu-c Jun 8, 2023
a15c700
Update packages/runtime-dom/src/helpers/useCssVars.ts
baiwusanyu-c Jun 9, 2023
c119208
fix(runtime-dom): updated code
baiwusanyu-c Jun 9, 2023
388b227
Merge branch 'main' into bwsy/fix/cssvarsAsync
baiwusanyu-c Jul 12, 2023
b5be96c
Merge branch 'main' into bwsy/fix/cssvarsAsync
baiwusanyu-c Jan 3, 2024
dc926fb
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 3, 2024
0a92213
Update useCssVars.ts
yyx990803 Apr 15, 2024
a8a21f5
Update useCssVars.ts
yyx990803 Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/runtime-dom/src/helpers/useCssVars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,16 @@ export function useCssVars(getter: (ctx: any) => Record<string, string>) {

const setVars = () => {
const vars = getter(instance.proxy)
baiwusanyu-c marked this conversation as resolved.
Show resolved Hide resolved
setVarsOnVNode(instance.subTree, vars)
// #8520
if (instance.asyncDep && __FEATURE_SUSPENSE__) {
baiwusanyu-c marked this conversation as resolved.
Show resolved Hide resolved
instance.asyncDep = new Promise(resolve => {
resolve(instance.asyncDep)
}).then(() => {
setVarsOnVNode(instance.subTree, vars)
})
} else {
setVarsOnVNode(instance.subTree, vars)
}
updateTeleports(vars)
}

Expand Down