-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(shared): improve test coverage #8456
Conversation
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #8456 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by the changes in your last commit. The second normalizeStyle
section has been entirely removed. While some of those tests were maybe duplicates of the tests in the other normalizeStyle
section, most of them did seem to be testing different things. When I mentioned the duplicate section in my earlier review I had intended for you to combine the tests into a single section, not remove them all.
I think those tests should be brought back.
I've included some other minor suggestions below.
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
No description provided.