Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(shared): improve test coverage #8456

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

Alfred-Skyblue
Copy link
Member

No description provided.

@pikax pikax added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Oct 20, 2023
Copy link

github-actions bot commented Nov 9, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB 37.5 kB 33.8 kB
vue.global.prod.js 157 kB 57.3 kB 51 kB

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.4 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.8 kB

Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #8456 will not alter performance

Comparing Alfred-Skyblue:test-shared (dd1df8f) with main (9fa8241)

Summary

✅ 53 untouched benchmarks

Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by the changes in your last commit. The second normalizeStyle section has been entirely removed. While some of those tests were maybe duplicates of the tests in the other normalizeStyle section, most of them did seem to be testing different things. When I mentioned the duplicate section in my earlier review I had intended for you to combine the tests into a single section, not remove them all.

I think those tests should be brought back.

I've included some other minor suggestions below.

packages/shared/__tests__/normalizeProp.spec.ts Outdated Show resolved Hide resolved
packages/shared/__tests__/normalizeProp.spec.ts Outdated Show resolved Hide resolved
packages/shared/__tests__/normalizeProp.spec.ts Outdated Show resolved Hide resolved
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit c30c1b8
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66c54e2f9ed0950008057f3f

Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit c30c1b8
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/66c54e2fc43073000725236d

Copy link

pkg-pr-new bot commented Aug 21, 2024

commit: b86ab94

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@8456

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@8456

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@8456

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@8456

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@8456

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@8456

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@8456

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@8456

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@8456

vue

pnpm add https://pkg.pr.new/vue@8456

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@8456

Open in Stackblitz

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Aug 21, 2024
@yyx990803 yyx990803 merged commit 4e19a99 into vuejs:main Oct 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged.
Projects
Development

Successfully merging this pull request may close these issues.

5 participants