Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): shallowRef type fix #7853

Merged
merged 7 commits into from
Nov 10, 2023
Merged

fix(reactivity): shallowRef type fix #7853

merged 7 commits into from
Nov 10, 2023

Conversation

simlevesque
Copy link
Contributor

Fixes #7852

Will update with a link to the issue in the upstream repo.
@LinusBorg LinusBorg added scope: types 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 8, 2023
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add unit tests to packages/dts-test/ref.test-d.ts?

@simlevesque
Copy link
Contributor Author

Done.

@sxzz
Copy link
Member

sxzz commented Mar 10, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Mar 10, 2023

📝 Ran ecosystem CI: Open

suite result
naive-ui ❌ failure
nuxt ✅ success
pinia ✅ success
router ✅ success
test-utils ✅ success
vant ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success
vue-macros ✅ success
vuetify ✅ success
vueuse ❌ failure

@simlevesque
Copy link
Contributor Author

I'm familiar with Vueuse, I'll try to find the problem and fix it with them.

# Conflicts:
#	packages/dts-test/ref.test-d.ts
@pikax
Copy link
Member

pikax commented Oct 24, 2023

/ecosystem-ci run

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 48 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@vue-bot
Copy link
Contributor

vue-bot commented Oct 24, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success failure
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse failure success
vue-simple-compiler success success

@pikax
Copy link
Member

pikax commented Oct 24, 2023

/ecosystem-ci run

@pikax
Copy link
Member

pikax commented Oct 24, 2023

VueUse is failing even with my changes, because they don't use MaybeRef that Vue provides, there's no way for us to resolve their issue, if they use Vue provided MaybeRef it will work

@vue-bot
Copy link
Contributor

vue-bot commented Oct 24, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success failure
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse failure success
vue-simple-compiler success success

@vue-bot
Copy link
Contributor

vue-bot commented Oct 24, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success failure
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@simlevesque
Copy link
Contributor Author

VueUse is failing even with my changes, because they don't use MaybeRef that Vue provides, there's no way for us to resolve their issue, if they use Vue provided MaybeRef it will work

That was my impression of it too... I couldn't reconcile both those things and in the end I had to work on other things. If you have any questions just ask me.

@yyx990803 yyx990803 merged commit 7c44800 into vuejs:main Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: types
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

shallowRef's return type should match ref's
6 participants