Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ignoreSideEffectTags): support style in svg #6592

Closed
wants to merge 2 commits into from

Conversation

azaleta
Copy link

@azaleta azaleta commented Sep 4, 2022

style should not be removed from context if it's in svg.
https://www.w3.org/TR/SVG2/styling.html

@netlify
Copy link

netlify bot commented Sep 4, 2022

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit e8d300d
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6314233d1672cd0008dcd502

@DrJume
Copy link
Contributor

DrJume commented Jun 12, 2023

This would be great. I always have to resort to SVGO to compile the <style> into inline styles...
Why are PRs with good ideas getting ignored?

@haoqunjiang
Copy link
Member

I think it's been well-discussed in vuejs/vue#11697
I don't think we'll accept a PR that simply keeps all the inline styles in SVG.

For escape hatches, I suggest opening an RFC at https://github.com/vuejs/rfcs/discussions to discuss detailed designs that can balance ease of use and the side-effect leakage concern.

@haoqunjiang haoqunjiang closed this Apr 3, 2024
@DrJume
Copy link
Contributor

DrJume commented Apr 3, 2024

Thank you for getting back to this PR.
The decision comes by surprise, as many have pointed out it's against the Web Standard and seems to be a idiosyncrasy of Vue.

Maybe instead of stripping the style tag completely, it could be replaced with a namespaced tag by Vue automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

3 participants