Refactor the assets resolution of the script setup #3546
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3543
with
<script setup>
, Assets(components/directives) will be tried to resolve from the setup state, this leads to naming conflicts between assets and ordinary variables, e.g.The constant
focus
in setup will overwrite the globally registered directive with the same name. This is because the above code will be compiled as:with
$setup["focus"]
, it will no longer perform asset resolution.My idea is that in order to avoid name conflicts, we should always perform asset resolution, which makes globally registered assets have a higher priority, and at the same time, use setup state as a fallback. E.g.
This behavior also applies to components resolution. And it only takes effect when there is a state with the same name in the setup result, without breaking anything.