fix(reactivity): ensure computed wrapped in readonly still works (close #3376) #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size report
|
LinusBorg
added
❗ p4-important
|
I added a test but would like input if there are more scenarios to cover. |
HcySunYang
reviewed
Mar 11, 2021
Comment on lines
202
to
206
| if ((target as any).__v_isRef && (target as any).effect) { | ||
| // computed should be able to set its own private properties | ||
| if (key === '_dirty' || key === '_value') { | ||
| return set(target, key, value, receiver) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we add __v_isComputed to ComputedRefImpl? like this:
class ComputedRefImpl<T> {
private _value!: T
private _dirty = true
public readonly effect: ReactiveEffect<T>
public readonly __v_isRef = true;
+ public readonly __v_isComputed = true;
public readonly [ReactiveFlags.IS_READONLY]: boolean
}I mean, this would be safer, consider the following scenario:
const data = ref({ effect: true })
const rData = readonly(data)
rData._value = 'xxx' // Unexpectedly with the __v_isComputed, we can implement the isComputed function, just like isRef.
There was a problem hiding this comment.
I'm a bit confused by the {effect: true} - that shouldn't have an impact, as that would be in target.value.effect, wouldn't it?
But nonetheless propably a safer approach., I agree.
There was a problem hiding this comment.
Oh sure, but you know what i mean 😄
LinusBorg
force-pushed
the
linusborg/fix-readonly-computed-3376
branch
from
ebe7c45 to
67f89fd
Compare
|
@HcySunYang I did the change you proposed, can you have a look? Thanks! |
HcySunYang
approved these changes
Mar 20, 2021
|
See cleaner fix in 41e02f0 |
|
Definitely the better solution, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping a
computed()inreadonly()breaks the computed's functionality.This PR ensures that such a wrapped computed can still set its internal proeprties
_dirty&_value, ensuring it can continue to work as expected.close #3376