Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): computed refs should not trigger watch if value has no change #2290

Closed
wants to merge 2 commits into from
Closed

fix(runtime-core): computed refs should not trigger watch if value has no change #2290

wants to merge 2 commits into from

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Oct 2, 2020

close #2231

@yyx990803
Copy link
Member

Thanks for the PR, but I think it's better to limit the force trigger logic to shallow refs only (which was why it was introduced) so isComputed would also be unnecessary. See 390589e

@yyx990803 yyx990803 closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watch triggered even if value is not changed
2 participants
@unbyte @yyx990803