fix: relax ComponentPublicInstanceConstructor type for class components #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, the type is used in |
ktsn
force-pushed
the
fix-constructor-type
branch
from
b63cb7a to
6d763a9
Compare
This comment has been minimized.
This comment has been minimized.
|
This seems to fail the tests introduced in 955450f |
yyx990803
reviewed
Aug 25, 2020
| @@ -107,7 +107,7 @@ export type ComponentPublicInstanceConstructor< | |||
| __isFragment?: never | |||
| __isTeleport?: never | |||
| __isSuspense?: never | |||
| new (): T | |||
| new (...args: never[]): T | |||
There was a problem hiding this comment.
Using any[] passes the tests - which I think is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix vuejs/vue-class-component#441
Because the current
ComponentPublicInstanceConstructoronly accepts a constructor with no arguments, class components are rejected as they receive two arguments under the hood.We can safely make the arguments type
(...args: never[])as the constructor will never be called in vue core.