New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(runtime-core): use ReactiveFlags #1902

Closed

edison1105 wants to merge 2 commits into vuejs:master from edison1105:ReactiveFlags

Member

edison1105 commented Aug 20, 2020

No description provided.

edison1105 added 2 commits

August 20, 2020 13:08


          chore(runtime-core): use ReactiveFlags

6faf89a


          chore(runtime-core): use ReactiveFlags

a597f16

Member

yyx990803 commented Aug 21, 2020

Thanks for the PR. Unfortunately this conflicts with #1900

I also tested with using const enum in class fields and turns out TS compiles it into a dynamic field assignment: https://www.typescriptlang.org/play?#code/MYewdgzgLgBApmArgWxgMQDYEMDmEYDeAUDKTAPIDSMAvDAOQBmcEzE9RAvkcNhPmhAhCJMgAdEAIwwBLYDABOcLABNwGAJ4wA2plwQAdFQC6tGFAWI4XIA - this probably has noticeable perf overhead that we'd want to avoid.

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet