-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types(reactivity): support DeepReadonly type #1462
Conversation
fetch new commit
fetch: rebase
Thanks for the PR! Could you please add a test case in |
Sure. |
Done. @yyx990803 |
this looks like a breaking change? |
This is not a new feature, it just improves type checking. |
As far as i understand before this PR you could do r.obj.k = 'x' and now you can't How can I now create shallow readonly variable so that r.obj = {}; // should fail
r.obj.k = 'x'; // should work ?
Maybe it should a new feature? Or is shallow readonly considered to be a feature that nobody needs? |
|
Ah I see, that makes perfectly sense |
fix #1452