Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): handle undefined values in v-html #11403

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix(runtime-dom): handle undefined values in v-html #11403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f5d23
fix(runtime-dom): handle undefined values in v-html
jh-leong Jul 19, 2024
c39af4a
test: add test
jh-leong Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/runtime-dom/__tests__/patchProps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ describe('runtime-dom: props patching', () => {
expect(root.innerHTML).toBe(`<div><del>baz</del></div>`)
})

test('patch innerHTML porp w/ undefined value', async () => {
const root = document.createElement('div')
render(h('div', { innerHTML: undefined }), root)
expect(root.innerHTML).toBe(`<div></div>`)
})

test('textContent unmount prev children', () => {
const fn = vi.fn()
const comp = {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-dom/src/modules/props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function patchDOMProp(
if (key === 'innerHTML' || key === 'textContent') {
// null value case is handled in renderer patchElement before patching
// children
if (value === null) return
if (value == null) return
el[key] = value
return
}
Expand Down