perf(server-renderer): optimize unrollBuffer
by avoiding promises
#11340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
unrollBuffer
is anasync
function, which results in approximately a 10x slowdown in a mixed buffer and around a 1.5x slowdown in a synchronous buffer. AnyPromise
on the hot path is a performance killer.In this PR,
unrollBuffer
will return aPromise
only if a child buffer does; otherwise, it will always operate synchronously. However, even if a child buffer returns aPromise
, we can continue to operate synchronously if further nesting is not required for another child buffer.Of course, there are other functions where something similar happens, such as
renderComponentVNode
, but this requires separate consideration.Performance was tested on the following hardware:
CPU:
AMD Ryzen 7950x3D
System:
WSL 2 Arch Linux on Windows 11
Node.js:
v22.4.0
Before
After