Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): infer TSIntersectionType #7394

Merged
merged 2 commits into from
Mar 28, 2023
Merged

fix(compiler-sfc): infer TSIntersectionType #7394

merged 2 commits into from
Mar 28, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Dec 22, 2022

@krystof-k krystof-k mentioned this pull request Dec 22, 2022
Closed
2 tasks
@Otto-J Otto-J mentioned this pull request Dec 27, 2022
Closed
@LinusBorg LinusBorg added the ready to merge The PR is ready to be merged. label Jan 9, 2023
@krystof-k krystof-k mentioned this pull request Jan 9, 2023
Merged
@sxzz sxzz force-pushed the fix/infer-ts-intersection branch from 90fbd9e to 522d6bc Compare January 26, 2023 17:13
@netlify
Copy link

netlify bot commented Jan 26, 2023

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 522d6bc
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63d2b4d8800d780008544eb3

@sxzz sxzz force-pushed the fix/infer-ts-intersection branch 2 times, most recently from abcfadc to f0186cf Compare February 4, 2023 17:39
@haoqunjiang haoqunjiang removed the ready to merge The PR is ready to be merged. label Feb 10, 2023
@sxzz sxzz force-pushed the fix/infer-ts-intersection branch from f0186cf to 51342ee Compare February 11, 2023 17:00
@vuejs vuejs deleted a comment from vue-bot Feb 11, 2023
@vuejs vuejs deleted a comment from vue-bot Feb 11, 2023
@vuejs vuejs deleted a comment from haoqunjiang Feb 11, 2023
@vuejs vuejs deleted a comment from haoqunjiang Feb 11, 2023
@sxzz
Copy link
Member Author

sxzz commented Feb 11, 2023

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Feb 11, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
router ✅ success
test-utils ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success
vue-macros ✅ success

@sxzz sxzz requested a review from haoqunjiang February 11, 2023 18:50
@sxzz sxzz force-pushed the fix/infer-ts-intersection branch from 51342ee to 81dadd2 Compare February 22, 2023 19:51
@qmhc qmhc mentioned this pull request Feb 24, 2023
Closed
3 tasks
@sxzz sxzz force-pushed the fix/infer-ts-intersection branch from 81dadd2 to cc01537 Compare March 27, 2023 23:44
@sxzz sxzz force-pushed the fix/infer-ts-intersection branch from cc01537 to b872fc3 Compare March 28, 2023 05:20
@yyx990803 yyx990803 merged commit 151a8ad into main Mar 28, 2023
@yyx990803 yyx990803 deleted the fix/infer-ts-intersection branch March 28, 2023 07:40
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
@sxzz @IAmSSH
fix(compiler-sfc): infer TSIntersectionType in defineProps (vuejs#7394)
a8637ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

@haoqunjiang haoqunjiang Awaiting requested review from haoqunjiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to import interface for defineProps
5 participants
@sxzz @vue-bot @LinusBorg @yyx990803 @haoqunjiang