Add tag and candidate filter to comparison #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kyjanond
commented
Jan 9, 2023
kyjanond
commented
- adds tags filtering for comparison page
- fixes scrolling and sticky header
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kyjanond
commented
Jan 9, 2023
| @@ -23,7 +22,7 @@ defineProps<Props>(); | |||
| corner="top-left" | |||
| border | |||
| shadow | |||
| padding="medium" | |||
| :padding="Object('medium')" | |||
There was a problem hiding this comment.
without Object it throws bunch of errors in the console. I don't understand the reasons really
kyjanond
commented
Jan 9, 2023
frontend/package.json
Outdated
| "@storybook/testing-library": "^0.0.13", | ||
| "@storybook/vue3": "^v7.0.0-beta.12", | ||
| "@storybook/vue3-vite": "^v7.0.0-beta.12", | ||
| "@storybook/addon-essentials": "^v7.0.0-beta.20", |
kyjanond
commented
Jan 9, 2023
frontend/package.json
Outdated
| @@ -66,10 +66,12 @@ | |||
| "prettier": "^2.5.1", | |||
| "prettier-plugin-sh": "^0.12.8", | |||
| "prisma": "^4.6.1", | |||
| "react": "^18.2.0", | |||
There was a problem hiding this comment.
needed by storybook
kyjanond
commented
Jan 9, 2023
| borderRadius: 'small', | ||
| // eslint-disable-next-line vue/require-valid-default-prop | ||
| padding: 'medium', | ||
| padding: Object('medium') as Props['padding'], |
There was a problem hiding this comment.
without Object it throws bunch of errors in the console. I don't understand the reasons really
There was a problem hiding this comment.
WTF? It may be related to the bug in Vue, which should be resolved soon by the vuejs/core#7394 PR (already approved).
krystof-k
reviewed
Jan 11, 2023
# Conflicts: # frontend/package-lock.json # frontend/package.json
krystof-k
force-pushed
the
filter-tags
branch
from
ea90256 to
50ac760
Compare
krystof-k
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.