Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No link to download an archive containing both the production version of vue 3 and the license file #2650

Closed
joudinet opened this issue Nov 20, 2020 · 5 comments · Fixed by #2857
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ✨ feature request New feature or request

Comments

@joudinet
Copy link

Version

3.0.2

Reproduction link

https://github.com/vuejs/vue-next/archive/v3.0.2.tar.gz

Steps to reproduce

The archive at https://github.com/vuejs/vue/archive/v2.6.12.tar.gz contains both the LICENSE file, which buildroot uses to verify the license hasn't changed without notice, and the dist/vue.min.js file which it installs on the production system.
In vue 3, the github archive does not contain the dist directory anymore.

What is expected?

Ideally, I would like a link to download an archive that contain both the production files and the license file, for a specific version of vue.

What is actually happening?

Using the same procedure as for vue2, I get an archive without the production files in it.


What is the official procedure to download vue3 production files?

@posva
Copy link
Member

posva commented Dec 7, 2020

The assets are now the source code without the dist files. The dist files are published on the npm registry so there must be a way to retrieve the actual url

@joudinet
Copy link
Author

joudinet commented Dec 7, 2020

Yes I can get a tarball from npm registry (e.g., https://registry.npmjs.org/vue/-/vue-3.0.4.tgz) but this tarball is missing the LICENSE file.

@posva
Copy link
Member

posva commented Dec 7, 2020

Yeah, so I think we could copy the LICENSE file from the root to all the packages when publishing. Right now it's not included because the License is only at the root folder

@LinusBorg LinusBorg added 🧹 p1-chore Priority 1: this doesn't change code behavior. ✨ feature request New feature or request labels Dec 21, 2020
@LinusBorg
Copy link
Member

@posva We can just copy the file to each package's root once. the tarball contains more than the /dist folder. This way, we don't have to adjust anything about the build system.

@posva
Copy link
Member

posva commented Dec 21, 2020

Agree, it's usually only one change per year (if any since there is present in the year), not worth automating

LinusBorg added a commit that referenced this issue Feb 3, 2021
catrope added a commit to catrope/vue-next that referenced this issue Jul 27, 2021
The vue-compat package was added after vuejs#2857 ensured that every package
has a LICENSE file
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.