Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fragment dynamic component with table keeps table element in dom in production mode #2553

Closed
posva opened this issue Nov 3, 2020 · 2 comments · Fixed by #2556
Closed

Fragment dynamic component with table keeps table element in dom in production mode #2553

posva opened this issue Nov 3, 2020 · 2 comments · Fixed by #2556
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working

Comments

@posva
Copy link
Member

posva commented Nov 3, 2020 •
edited
Loading

Version

3.0.2

Reproduction link

https://github.com/posva/vue-next-vite-table-dynamic-component-bug

Steps to reproduce

  • yarn build
  • serve the fist folder (prod like)
  • Click on Table button
  • Click on Index button

What is expected?

The table should disappear

What is actually happening?

it stays when going back to index

Couldn't reproduce on a jsfiddle: https://jsfiddle.net/0e8wza4g/

From vuejs/router#572
@posva posva mentioned this issue Nov 3, 2020
Closed
@posva posva added the 🐞 bug Something isn't working label Nov 3, 2020
@edison1105
Copy link
Member

@posva I clone your repo but it works correctly, could not reproduce.

@posva posva changed the title Fragment dynamic component with table keeps table element in dom Fragment dynamic component with table keeps table element in dom in production mode Nov 4, 2020
@posva
Copy link
Member Author

posva commented Nov 4, 2020

Forgot to say it only happens in production! Updated the issue to reflect it

underfin added a commit to underfin/vue-next that referenced this issue Nov 4, 2020
@underfin
fix(runtime-core): remove static node in production mode
78ae346 
fix vuejs#2553
@underfin underfin mentioned this issue Nov 4, 2020
Merged
@posva posva added the has PR A pull request has already been submitted to solve the issue label Nov 18, 2020
yyx990803 pushed a commit that referenced this issue Nov 30, 2020
@underfin
fix(runtime-core): remove static node in production mode (#2556)
2a9ba0c 
fix #2553
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): remove static node in production mode underfin/vue-next
2 participants
@posva @edison1105