-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The bug in the v-show directive of v3.4.16 causes the components to not display. #10294
Comments
yes, v-if v-show has problem |
Hi, |
Related issues vuetifyjs/vuetify#19194 vuetifyjs/vuetify#19191 vuejs/core#10294 Keep Vue version v3.4.15 until these issues be resolved
It seems like a vast majority of the "v-(anything)" properties are acting up. I was having v-model and v-for issues as well. |
Also a problem with primevue: |
I have same problem with Vue 3 and Ant Design without update any dependency, I just rebuild my project cleaning package-lock.json and node_modules and this bug appears. All components with the effect of showing something on the screen had the error of not changing their style after the click or hover event. It also be noted that the use of "display: none" is common in all components that present an error. |
Same problem here after my project is rebuilded... I tried to downgrade Vue but without success, I'm desperate, any suggestions? |
This problem definitely only occurs with Vue 3.4.16, so check that you're using an earlier Vue version |
make sure you have the exact
not
|
Same issue, noticed it with very easy usecase:
And once activeItem changes (but not to 'data'), the button simply disappears. All fine in 3.4.15 so downgraded too. |
The problematic commit has been reverted in 3.4.17. |
Problem is also with v-list-group. Try to click on Admin or Actions group it shows nothing. Example is from official vuetify.com. v-list-group stopped working with VUE > 3.4.15 |
Add a new PR to fix it in #10311 |
Also having an issue with modals. Confirm not working again in 3.4.18. The builds with the issue cause a modal dialog to appear when loading the page ( a table with multiple modals not shown per row). |
I think 3.4.19 fixed this |
Maybe this exact issue was fixed, but in our applications several of our modals now pop-up when the app starts up, rather than being hidden. I'll see if I can create a minimal reproduction and create a new issue. We'll probably just downgrade to 3.4.15 for now. Created #10338 |
…a v-bind (vuejs#10161) This reverts commit 9b19f09. close vuejs#10294 reopen vuejs#10151
Vue version
3.4.16
Link to minimal reproduction
Element Plus Playground
Steps to reproduce
You can test it at the link above. Choose
Element Plus version 2.5.5
andVue version 3.4.16
. After selecting, you will notice that clicking theel-select
dropdown does not display anything. Checking the console, it's observed that the popup layer is set todisplay: none
, causing it not to show. Switching Vue version to3.4.15
restores normal functionality.After investigation, it's found that the following two changes under v3.4.16 caused this issue. I tested locally and directly reverted these two changes in the code under node_modules
runtime-dom/dist
, which restored normal functionality.Besides
el-select
, there are many other components that are not displayed properly, such asel-container
,el-menu
,el-scrollbar
,el-overlay
, etc. After examining the code, it's noticed that these components are all implemented using rendering functions. Components using template seem to display correctly.v3.4.15...v3.4.16
9b19f09
core/packages/runtime-dom/src/directives/vShow.ts
Line 25 in 1339330
core/packages/runtime-dom/src/modules/style.ts
Line 41 in 1339330
// indicates that the `display` of the element is controlled by `v-show`, // so we always keep the current `display` value regardless of the `style` // value, thus handing over control to `v-show`. if (vShowOldKey in el) { + el[vShowOldKey] = style.display style.display = currentDisplay }
v3.4.16 版本会导致 element-plus 所有用渲染函数创建的组件都无法显示
可以在上面的链接测试,Element Plus版本选择2.5.5,Vue版本选择3.4.16,选择后可以发现点击
el-select
下拉框无法显示,看控制台发现是弹出层被设为了display: none
导致无法显示,将Vue版本切换为 3.4.15 后恢复正常。排查后发现是 v3.4.16 这两个改动导致的,我本地测试直接改了 node_modules下的
runtime-dom/dist
的代码还原这两个改动后就恢复正常。除了 el-select, 无法显示的组件还有很多,比如
el-container
、el-menu
、el-scrollbar
、el-overlay
等,看了下代码,发现这些组件都是用渲染函数实现的,使用 template 的组件好像都正常显示。What is expected?
Displayed normally.
What is actually happening?
Not displayed.
System Info
No response
Any additional comments?
No response
The text was updated successfully, but these errors were encountered: