fix(compiler-core): ignore comment nodes in transition children

fix #1352
vuejs · Jun 15, 2020 · e52b7cd · e52b7cd
1 parent afb231e
commit e52b7cd
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/compiler-dom/src/transforms/warnTransitionChildren.ts b/packages/compiler-dom/src/transforms/warnTransitionChildren.ts
@@ -34,9 +34,13 @@ export const warnTransitionChildren: NodeTransform = (node, context) => {
 }
 
 function hasMultipleChildren(node: ComponentNode | IfBranchNode): boolean {
-  const child = node.children[0]
+  // #1352 filter out potential comment nodes.
+  const children = (node.children = node.children.filter(
+    c => c.type !== NodeTypes.COMMENT
+  ))
+  const child = children[0]
   return (
-    node.children.length !== 1 ||
+    children.length !== 1 ||
     child.type === NodeTypes.FOR ||
     (child.type === NodeTypes.IF && child.branches.some(hasMultipleChildren))
   )