fix(runtime-core): v-memo work with v-if

vuejs · Sep 5, 2022 · b3b89bc · b3b89bc
1 parent fa6556a
commit b3b89bc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/packages/runtime-core/src/helpers/withMemo.ts b/packages/runtime-core/src/helpers/withMemo.ts
@@ -15,6 +15,9 @@ export function withMemo(
 
   // shallow clone
   ret.memo = memo.slice()
+
+  ret.cleanMemoCache = () => cache[index] = undefined
+
   return (cache[index] = ret)
 }
 

diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -2085,6 +2085,11 @@ function baseCreateRenderer(
       setRef(ref, null, parentSuspense, vnode, true)
     }
 
+    // #6593 should clean memo cache when unmount 
+    if (vnode.cleanMemoCache) { 
+      vnode.cleanMemoCache()
+    }
+
     if (shapeFlag & ShapeFlags.COMPONENT_SHOULD_KEEP_ALIVE) {
       ;(parentComponent!.ctx as KeepAliveContext).deactivate(vnode)
       return

diff --git a/packages/runtime-core/src/vnode.ts b/packages/runtime-core/src/vnode.ts
@@ -206,6 +206,10 @@ export interface VNode<
    * @internal attached by v-memo
    */
   memo?: any[]
+  /**
+   * @internal clean v-memo cache
+   */
+  cleanMemoCache?: Function
   /**
    * @internal __COMPAT__ only
    */