refactor: use index instead of function

vuejs · Jun 7, 2024 · b0617e5 · b0617e5
1 parent 50126ca
commit b0617e5
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/packages/runtime-core/src/component.ts b/packages/runtime-core/src/component.ts
@@ -322,7 +322,7 @@ export interface ComponentInternalInstance {
    * after initialized (e.g. inline handlers)
    * @internal
    */
-  renderCache: (Function | VNode)[]
+  renderCache: (Function | VNode | undefined)[]
 
   /**
    * Resolved component registry, only for components with mixins or extends

diff --git a/packages/runtime-core/src/helpers/withMemo.ts b/packages/runtime-core/src/helpers/withMemo.ts
@@ -15,8 +15,7 @@ export function withMemo(
 
   // shallow clone
   ret.memo = memo.slice()
-
-  ret.cleanMemoCache = () => (cache[index] = undefined)
+  ret.memoIndex = index
 
   return (cache[index] = ret)
 }

diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -2110,15 +2110,16 @@ function baseCreateRenderer(
       shapeFlag,
       patchFlag,
       dirs,
+      memoIndex,
     } = vnode
     // unset ref
     if (ref != null) {
       setRef(ref, null, parentSuspense, vnode, true)
     }
 
     // #6593 should clean memo cache when unmount
-    if (vnode.cleanMemoCache) {
-      vnode.cleanMemoCache()
+    if (memoIndex != null) {
+      parentComponent!.renderCache[memoIndex] = undefined
     }
 
     if (shapeFlag & ShapeFlags.COMPONENT_SHOULD_KEEP_ALIVE) {

diff --git a/packages/runtime-core/src/vnode.ts b/packages/runtime-core/src/vnode.ts
@@ -229,9 +229,9 @@ export interface VNode<
    */
   memo?: any[]
   /**
-   * @internal clean v-memo cache
+   * @internal index for cleaning v-memo cache
    */
-  cleanMemoCache?: Function
+  memoIndex?: number
   /**
    * @internal __COMPAT__ only
    */