fix(types): components options should accept components defined with …

…defineComponent (#602)
vuejs · Jan 13, 2020 · 74baea1 · 74baea1
1 parent 63a6563
commit 74baea1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/runtime-core/src/apiOptions.ts b/packages/runtime-core/src/apiOptions.ts
@@ -63,7 +63,10 @@ export interface ComponentOptionsBase<
   // Luckily `render()` doesn't need any arguments nor does it care about return
   // type.
   render?: Function
-  components?: Record<string, Component>
+  components?: Record<
+    string,
+    Component | { new (): ComponentPublicInstance<any, any, any, any, any> }
+  >
   directives?: Record<string, Directive>
   inheritAttrs?: boolean
 

diff --git a/test-dts/defineComponent.test-d.tsx b/test-dts/defineComponent.test-d.tsx
@@ -259,3 +259,11 @@ describe('compatibility w/ createApp', () => {
   })
   createApp().mount(comp3, '#hello')
 })
+
+describe('defineComponent', () => {
+  test('should accept components defined with defineComponent')
+  const comp = defineComponent({})
+  defineComponent({
+    components: { comp }
+  })
+})