fix(reactivity): add NaN prop on Array should not trigger length depe…

…ndency. (#1998)
vuejs · Sep 15, 2020 · 0d4910a · 0d4910a
1 parent 124c385
commit 0d4910a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/reactivity/__tests__/reactiveArray.spec.ts b/packages/reactivity/__tests__/reactiveArray.spec.ts
@@ -124,6 +124,8 @@ describe('reactivity/reactive/Array', () => {
     expect(fn).toHaveBeenCalledTimes(1)
     observed[-1] = 'x'
     expect(fn).toHaveBeenCalledTimes(1)
+    observed[NaN] = 'x'
+    expect(fn).toHaveBeenCalledTimes(1)
   })
 
   describe('Array methods w/ refs', () => {

diff --git a/packages/shared/src/index.ts b/packages/shared/src/index.ts
@@ -87,7 +87,10 @@ export const isPlainObject = (val: unknown): val is object =>
   toTypeString(val) === '[object Object]'
 
 export const isIntegerKey = (key: unknown) =>
-  isString(key) && key[0] !== '-' && '' + parseInt(key, 10) === key
+  isString(key) &&
+  key !== 'NaN' &&
+  key[0] !== '-' &&
+  '' + parseInt(key, 10) === key
 
 export const isReservedProp = /*#__PURE__*/ makeMap(
   'key,ref,' +