Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asset handling for support vite dev. #90

Merged
merged 3 commits into from
Jul 22, 2020
Merged

feat: asset handling for support vite dev. #90

merged 3 commits into from
Jul 22, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented Jul 4, 2020 •
edited
Loading

###Description
I'm work on run vue2.x with vite.The vite dev need relative url resolve based on baseUrl.
Thanks for your gugs take a look.

haoqunjiang
haoqunjiang reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me. But it would be better if there're corresponding unit tests.

@underfin
Copy link
Member Author

Has test done :)

@haoqunjiang haoqunjiang merged commit ad83bdf into vuejs:master Jul 22, 2020
@underfin underfin deleted the resolve-asset-url-vite branch July 22, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@underfin @haoqunjiang