fix TypeScript error when multiple clients are used #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-re
suggested changes
Jan 29, 2018
types/vue-apollo.d.ts
Outdated
| @@ -21,7 +21,7 @@ type VueApolloOptions = { | |||
| export class VueApollo implements PluginObject<{}> { | |||
| [key: string]: any; | |||
| install: PluginFunction<{}>; | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions }); | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions, clients: { [key: string]:any } }); | |||
There was a problem hiding this comment.
@azulite
thanks! this is my mistake 🙇
Client property is optional value, so could you change it to type of optional value?
https://www.typescriptlang.org/docs/handbook/functions.html#optional-and-default-parameters
And I'm glad to run yarn run test:types on your local machine.(Your changes cause to fail tests...)
joe-re
reviewed
Jan 29, 2018
types/vue-apollo.d.ts
Outdated
| @@ -21,7 +21,7 @@ type VueApolloOptions = { | |||
| export class VueApollo implements PluginObject<{}> { | |||
| [key: string]: any; | |||
| install: PluginFunction<{}>; | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions }); | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions, clients: { [key: string]:any } }); | |||
There was a problem hiding this comment.
I think it is better to use ApolloClient<{}>[] instead of any.
azulite
commented
Jan 31, 2018
types/vue-apollo.d.ts
Outdated
| @@ -21,7 +21,7 @@ type VueApolloOptions = { | |||
| export class VueApollo implements PluginObject<{}> { | |||
| [key: string]: any; | |||
| install: PluginFunction<{}>; | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions }); | |||
| constructor (options: { defaultClient: ApolloClient<{}>, defaultOptions?: VueApolloOptions, clients: { [key: string]:any } }); | |||
There was a problem hiding this comment.
Ahhh yes I should run test and thank you for your suggestions! I am getting myself familiar with TypeScript still, your TS file saved my day 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I am working on a project with Vue and Typescript. When I try to define multiple endpoints with below code:
There has TypeScript error that is described at below: