fix: should properly stop and restart subcribe to more subs after que…

…ry is restarted, closes #677
vuejs · Sep 30, 2019 · 9546360 · 9546360
1 parent 970dc2b
commit 9546360
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/dollar-apollo.js b/src/dollar-apollo.js
@@ -150,6 +150,10 @@ export class DollarApollo {
       const smart = this.subscriptions[key] = new SmartSubscription(this.vm, key, options, false)
       smart.autostart()
 
+      if (options.linkedQuery) {
+        options.linkedQuery._linkedSubscriptions.push(smart)
+      }
+
       return smart
     }
   }

diff --git a/src/smart-query.js b/src/smart-query.js
@@ -5,6 +5,7 @@ export default class SmartQuery extends SmartApollo {
   type = 'query'
   vueApolloSpecialKeys = VUE_APOLLO_QUERY_KEYWORDS
   _loading = false
+  _linkedSubscriptions = []
 
   constructor (vm, key, options, autostart = true) {
     // Add reactive data related to the query
@@ -86,6 +87,11 @@ export default class SmartQuery extends SmartApollo {
         return
       }
       this.sub.unsubscribe()
+
+      // Subscribe to more subs
+      for (const sub of this._linkedSubscriptions) {
+        sub.stop()
+      }
     }
 
     this.previousVariablesJson = variablesJson
@@ -104,6 +110,11 @@ export default class SmartQuery extends SmartApollo {
     }
 
     super.executeApollo(variables)
+
+    // Subscribe to more subs
+    for (const sub of this._linkedSubscriptions) {
+      sub.start()
+    }
   }
 
   startQuerySubscription () {