-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: try italic problem #574
Conversation
✅ Deploy Preview for vue-docs-zh-cn ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.vitepress/theme/styles/zh-cn.css
Outdated
@@ -7,9 +7,12 @@ | |||
} | |||
|
|||
body { | |||
--vt-font-family-base: Quotes, Inter, -apple-system, BlinkMacSystemFont, | |||
--vt-font-family-base: Quotes, 'Inter var experimental', 'Inter var', -apple-system, BlinkMacSystemFont, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these 2 fonts are not defined in vuejs/theme (used as doc theme) but vitepress/theme-default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works (win10) btw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it related to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it related to this?
Looks like it is. But now can we remove the Inter
font instead of using 'Inter var experimental', 'Inter var'
? Since it's not defined in vuejs/theme, I think there's no difference. And it's also better to add some comments on this.
We can rise PR to vuejs/theme later for these changes, and sync back here after they works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I have Inter fonts first? but consider whether deleting Inter fonts will have other effects.
remove Inter Font
Description of Problem
#571 I tried to solve this problem. You need to verify it.☺️