Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try italic problem #574

Merged
merged 3 commits into from
Oct 13, 2022
Merged

fix: try italic problem #574

merged 3 commits into from
Oct 13, 2022

Conversation

zhousg
Copy link
Contributor

@zhousg zhousg commented Oct 11, 2022

Description of Problem

#571 I tried to solve this problem. You need to verify it. ☺️

@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for vue-docs-zh-cn ready!

Name Link
🔨 Latest commit 1b19cec
🔍 Latest deploy log https://app.netlify.com/sites/vue-docs-zh-cn/deploys/6347d8dfa16f360008e362f2
😎 Deploy Preview https://deploy-preview-574--vue-docs-zh-cn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cn-vuejs-org ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 9:23AM (UTC)

@@ -7,9 +7,12 @@
}

body {
--vt-font-family-base: Quotes, Inter, -apple-system, BlinkMacSystemFont,
--vt-font-family-base: Quotes, 'Inter var experimental', 'Inter var', -apple-system, BlinkMacSystemFont,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these 2 fonts are not defined in vuejs/theme (used as doc theme) but vitepress/theme-default

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works (win10) btw

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuejs/vitepress#777

Is it related to this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vuejs/vitepress#777

Is it related to this?

Looks like it is. But now can we remove the Inter font instead of using 'Inter var experimental', 'Inter var'? Since it's not defined in vuejs/theme, I think there's no difference. And it's also better to add some comments on this.

We can rise PR to vuejs/theme later for these changes, and sync back here after they works.

Copy link
Contributor Author

@zhousg zhousg Oct 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I have Inter fonts first? but consider whether deleting Inter fonts will have other effects.

remove Inter Font
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants