Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try and replace custom dev-server with webpack-dev-server #964

Closed
5 of 6 tasks
LinusBorg opened this issue Oct 9, 2017 · 2 comments
Closed
5 of 6 tasks

Try and replace custom dev-server with webpack-dev-server #964

LinusBorg opened this issue Oct 9, 2017 · 2 comments

Comments

@LinusBorg
Copy link
Contributor

LinusBorg commented Oct 9, 2017

Originally, back in the day, we came up with our own dev-server implementation because webpack-dev-server because at that time, it was lacking some features, like the error-overlay.

Since then, it hs improved significantly, and I'm not aware of any particular noteworthy advantage of your custom devserver over webpack's.

So I'll look into this a bit more, and if there really is no advantage left, I will work out a PR to switch the template to webpack-dev-server.

This will remove the maintainance burden for the dev server from this template and also makes it more approachable for people already familiar with webpack-dev-server.

TODO

  • Check feature parity (sucess!)
  • change webpack config and package.json scripts to use webpack-dev-server
  • Test this setup.
  • remove dead code.
  • review and close PRs / notify contributors of those PRs that may still target the now removed dev-server code.
  • Review & test
@haidongsong
Copy link

# I'm a rookie, and I follow a video to learn to do app, and I edit and modify the dev-server.js in the video. I don't have this document. What do I do?

@LinusBorg
Copy link
Contributor Author

I don't know what you are told to change, so I can't say what that means with the new dev server.

frandiox pushed a commit to OnsenUI/vue-cordova-webpack that referenced this issue Dec 25, 2017
…ates#975)

* Finished testable version.

* close vuejs-templates#960

* fix node-notifier version

* remove console.log

* moved general dependency out of unit test-only dependency block.

* fix typo

* ignore /test folder

* make HMR work correctly.

* improve console messages for HMR - now show filenames of replaced modules.

* fix typo in eslint-loader config

* move imports for the env files from /config/index.js directly into the webpack config.

Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js

* fix wrong overlay config
shenron pushed a commit to shenron/webpack that referenced this issue Mar 20, 2018
…ates#975)

* Finished testable version.

* close vuejs-templates#960

* fix node-notifier version

* remove console.log

* moved general dependency out of unit test-only dependency block.

* fix typo

* ignore /test folder

* make HMR work correctly.

* improve console messages for HMR - now show filenames of replaced modules.

* fix typo in eslint-loader config

* move imports for the env files from /config/index.js directly into the webpack config.

Reasoning: thosen file imports are not configuration, so they don't belong inside of config/index.js

* fix wrong overlay config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants