Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in IE11 and Edge #473

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Fix bug in IE11 and Edge #473

merged 1 commit into from
Jul 10, 2018

Conversation

lionel-bijaoui
Copy link
Member

@lionel-bijaoui lionel-bijaoui commented Jun 27, 2018 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix a bug with valueAsNumber and IE11 and Edge
  • What is the current behavior?** (You can also link to an open issue here)
    IE11 and Edge return NaN even with number
  • What is the new behavior (if this is a feature change)?
    Should return the good value
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

@lionel-bijaoui lionel-bijaoui requested review from zoul0813 and dflock July 5, 2018 16:09
zoul0813
zoul0813 approved these changes Jul 5, 2018
View reviewed changes
Copy link
Member

@zoul0813 zoul0813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@lionel-bijaoui lionel-bijaoui merged commit b676cae into vue-generators:master Jul 10, 2018
@lionel-bijaoui lionel-bijaoui deleted the lb_fix_valueAsNumber branch July 10, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoul0813 zoul0813 zoul0813 approved these changes

@dflock dflock Awaiting requested review from dflock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionel-bijaoui @zoul0813