Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scoped styles #20

Closed
5 tasks done
icebob opened this issue Aug 2, 2016 · 14 comments
Closed
5 tasks done

remove scoped styles #20

icebob opened this issue Aug 2, 2016 · 14 comments
Milestone

Comments

@icebob
Copy link
Member

icebob commented Aug 2, 2016

@icebob icebob added this to the v0.4.0 milestone Aug 3, 2016
@icebob
Copy link
Member Author

icebob commented Aug 8, 2016

@lionel-bijaoui so we need to remove scoped from styles and use the extractTextPlugin in webpack to extract styles.

@icebob icebob mentioned this issue Aug 8, 2016
9 tasks
@lionel-bijaoui
Copy link
Member

I can base myself on the webpack vue-cli template.

@icebob
Copy link
Member Author

icebob commented Aug 8, 2016

This code is from my other project where I'm using ExtractTextPlugin for sccs extraction:
https://gist.github.com/icebob/b7ebfe9ca4494b380fb3fe2442e97f7f

@lionel-bijaoui
Copy link
Member

lionel-bijaoui commented Aug 8, 2016

  • Extract styles to a vue-form-generator.css file.

I don't know how this css should be linked. If I use npm to install vue-form-generator, should I get the css or should I download it elsewhere ?

@icebob
Copy link
Member Author

icebob commented Aug 8, 2016

in Vue you can import as a npm js module from node_modules... (I think :) )

import style from "vue-form-generator/dist/vue-form-generator.css"

@lionel-bijaoui
Copy link
Member

Ok, I don't have anything else to do on the files then. I found a way to
keep my fork in sync with the project (RTFM, right ? 😄 ). Once I'm
finished configuring, I will do a PR.

Le 8 août 2016 16:11, "Icebob" [email protected] a écrit :

in Vue you need to import as a npm js module from node_modules... (I think
:) )

import style from "vue-form-generator/dist/vue-form-generator.css"


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#20 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADT81CaEqFgSLR-Wv4OQVhg4yAZW8EHqks5qdzkMgaJpZM4JaYBx
.

@icebob
Copy link
Member Author

icebob commented Aug 8, 2016

@lionel-bijaoui
Copy link
Member

I would like to do the alternative style if possible.

@icebob
Copy link
Member Author

icebob commented Aug 9, 2016

Ok, it would be good!

@icebob icebob mentioned this issue Aug 9, 2016
@icebob
Copy link
Member Author

icebob commented Aug 10, 2016

@lionel-bijaoui would you like to create a custom css styles to demonstrate this new feature on fiddle or codepen or webpackbin? Not problem if not.

@lionel-bijaoui
Copy link
Member

Yeah, I was waiting for the official fiddle to start hacking :)

@icebob
Copy link
Member Author

icebob commented Aug 10, 2016

Great! You can use it as a base. It is updated and removed bootstrap dependency: https://jsfiddle.net/icebob/0mg1v81e/

@lionel-bijaoui
Copy link
Member

Done : https://jsfiddle.net/0mg1v81e/31/
I used this example (Form Style 4) to get started. I hope you like the result.

@icebob
Copy link
Member Author

icebob commented Aug 10, 2016

Great! Good job!

@icebob icebob closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants