Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only Main process tries to set state #30

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

michaeljpeake
Copy link

My testing (on Windows only) has found frequent file errors caused by one or more renderers trying to write the store state to disk at the same time as the main process.

The if statement I have added prevents processes of type renderer from duplicating the work of the main process.

Fixes #27

@Bomberus
Copy link

Bomberus commented Mar 6, 2019

Short question, why do you check for: process.env.NODE_ENV === "test" ?
Will this be false, once I deploy my electron app?

@michaeljpeake
Copy link
Author

Short question, why do you check for: process.env.NODE_ENV === "test" ?
Will this be false, once I deploy my electron app?

This is to allow the tests to run, as they do not create an Electron browser (main) process.

@Bomberus
Copy link

Bomberus commented Mar 7, 2019

Thanks, good to know.

@akodkod
Copy link
Contributor

akodkod commented Aug 29, 2019

#44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bad file descriptor errors
4 participants