Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use relative path for table links #1135

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Thyumo
Copy link
Contributor

@Thyumo Thyumo commented Jun 10, 2024

Description of the issue

On the page Rule Overview:

  • Left clicking on the links in the table navigates to the Getting started page
  • Middle clicking on the links in the table navigates to https://vue-a11y.github.io/rules/{ruleName} (e.g. https://vue-a11y.github.io/rules/alt-text)

Suggested fix

It seems like the base URL (/eslint-plugin-vuejs-accessibility/) is ignored. I think this is because the table is in a .vue file and we're using a <a> tag directly.

So I suggest switching to a relative path to link to the rule: ../rules/{rule-name}

@vhoyer vhoyer merged commit 2c8a293 into vue-a11y:main Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants