use first non development version as download if possible #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsykun
reviewed
Oct 18, 2024
| } | ||
| } | ||
| } | ||
| return $matchedVersions[0]->first(); |
There was a problem hiding this comment.
$matchedVersions[0]->first() may return false
| @@ -536,7 +536,18 @@ public function getVersions() | |||
|
|
|||
| public function getVersionByReference(string $reference): ?Version | |||
| { | |||
| return $this->versions->findFirst(fn($k, $v) => $v->getReference() === $reference); | |||
| /** @var ArrayCollection[] $matchedVersions */ | |||
| $matchedVersions = $this->versions->partition(fn($k, $v) => $v->getReference() === $reference); | |||
There was a problem hiding this comment.
Please use filter method here
$this->versions->filter(fn($k, $v) => $v->getReference() === $reference);
vtsykun
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the first version is sometimes that the first version (depending on import) is a dev version with a source to a forbidden gitlab/github repo.
Only the non-development version omits the source and has only a dist with a download.
This results in a 401, if the zipball wants to download the dev version, not the non-development version.