Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lighthouse complaining about robots.txt #89

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

tlgimenes
Copy link
Contributor

What's the purpose of this pull request?

Fix lighthouse complaining about robots.txt.

@tlgimenes tlgimenes added the Bug Fixes Something isn't working label Jun 2, 2022
@tlgimenes tlgimenes requested a review from a team June 2, 2022 14:57
@vercel
Copy link

vercel bot commented Jun 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-store-storybook ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 4:55PM (UTC)

@tlgimenes tlgimenes force-pushed the fix/lighthouse-seo-robots branch from ea8f1f2 to 1bcc7b7 Compare June 2, 2022 14:57
@vercel vercel bot temporarily deployed to preview June 2, 2022 15:00 Inactive
@vtex-sites
Copy link

vtex-sites bot commented Jun 2, 2022

Preview is ready

This pull request generated a Preview

👀   Preview: https://sfj-032fe29--nextjs.preview.vtex.app
🔬   Go deeper by inspecting the Build Logs
📝   based on commit 032fe29

@vtex-sites
Copy link

vtex-sites bot commented Jun 2, 2022

Lighthouse Reports

Here are the Lighthouse reports of this Pull Request

📝 Based on commit 032fe29

Lighthouse Report by page
📎   /
📎   /apple-magic-mouse-99988212/p
📎   /office

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remember to update the changelog, ok? 🙂

Copy link
Contributor

@filipewl filipewl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes this:
CleanShot 2022-06-02 at 12 59 33

👏

After @hellofanny's suggestion, this looks good to me as well!

Co-authored-by: Fanny Chien <[email protected]>
@vercel vercel bot temporarily deployed to preview June 2, 2022 16:53 Inactive
@vercel vercel bot temporarily deployed to preview June 2, 2022 16:55 Inactive
@tlgimenes tlgimenes merged commit 032fe29 into main Jun 2, 2022
@tlgimenes tlgimenes deleted the fix/lighthouse-seo-robots branch June 2, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fixes Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants