feat: Adjust Alert for CMS #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
saranicoly
approved these changes
May 12, 2022
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-8923df7--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 8923df7
|
filipewl
approved these changes
May 12, 2022
|
Remember to add a new entry to the changelog. |
danzanzini
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR will replicate the changes made in this gatsby.store PR.
How does it work?
The
Alert(in thesrc/common/Alertfolder) will get the propertiesicon,text,linkText,actionLinkanddismissible, instead of just receiving everything as children (and hardcoded, like theiconand thedismissibleproperties)How to test it?
Nothing special to be tested, the
Alertwill be displayed exactly as before. It will just make the props available, so we can use them in a future PR in storeframework.store.References
Related Jira task
Checklist
Added an entry in the
CHANGELOG.mdat the beginning of its due section. The latest version should come first.Added the PR number with the PR link at the entry in the
CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR description
Added a label according to the PR goal -
Breaking change,Enhancement,BugorChore.Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g.,
ComponentNamecomponent.