feat: Adds new tokens to Skeleton
#171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasfp13
added
Chore
lucasfp13
force-pushed
the
feat/FS-269-add-new-tokens-to-skeleton
branch
from
6e2d583 to
4002844
Compare
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-171--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 2cfbe7a
|
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
We will, I'm already working on them 🔛 |
lucasfp13
force-pushed
the
feat/FS-269-add-new-tokens-to-skeleton
branch
from
4002844 to
3fbd4f9
Compare
There was a problem hiding this comment.
Amazing Job, @lucasfp13!
You also included ProductShelf 🎉
Sometimes I'm in doubt if we need some tokens, especially the ones with width or height with 100% or 0 values.
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/FilterSkeleton.stories.mdx
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
...ponents/skeletons/ProductTilesSkeleton/ProductTileSkeleton/product-tile-skeleton.module.scss
Outdated
Show resolved
Hide resolved
hellofanny
reviewed
Jul 20, 2022
hellofanny
reviewed
Jul 20, 2022
|
|
||
| # Skeletons | ||
|
|
||
| This feature improves the store's experience and perceived performance through loading placeholders. |
There was a problem hiding this comment.
Why are we classifying skeletons components as a feature?
There was a problem hiding this comment.
Nice question! I also wonder about it.
There was a problem hiding this comment.
I discussed this with @renatamottam, and it makes sense to be a feature for her, also I agree that it is ok so then we group all skeletons
lucasfp13
force-pushed
the
feat/FS-269-add-new-tokens-to-skeleton
branch
from
4ea3489 to
f80fcdb
Compare
lucasfp13
force-pushed
the
feat/FS-269-add-new-tokens-to-skeleton
branch
from
0da3e8c to
bb90f0e
Compare
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/ProductCardSkeleton/product-card-skeleton.module.scss
Outdated
Show resolved
Hide resolved
src/components/skeletons/FilterSkeleton/filter-skeleton.module.scss
Outdated
Show resolved
Hide resolved
lucasfp13
force-pushed
the
feat/FS-269-add-new-tokens-to-skeleton
branch
from
afb3dc7 to
914fd26
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to apply new tokens to
Skeletonand its related components, based on the new Theming structure: new scoped tokens linked to global ones.It also uses FastStore UI's
Skeletoncomponent and renamesSkeletonElementtoSkeletonfor a better code understanding/legibility.How does it work?
This PR uses local variables to parameterize the
Skeletonand its related components' properties, then connects these scoped tokens to the global ones.How to test it?
These changes should not affect the skeletons' behavior. It can be tested through browser developer tools, applying a network throttling to simulate, for instance, a slow 3g connection.
skeleton.mov
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation