-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Transfers responsibility of InputText
's main attributes and callbacks to the renderer
#163
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-8bff5a0--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 8bff5a0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
InputText
's main attributes and callbacks to the rendererInputText
's main attributes and callbacks to the renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just a minor nitpick
8dedcc5
to
5dbfc80
Compare
5dbfc80
to
45f6500
Compare
InputText
's main attributes and callbacks to the rendererInputText
's main attributes and callbacks to the renderer
What's the purpose of this pull request?
This PR intends to fix the
InputText
by removing some component's local implementation, which should be the responsibility of the parent component that is rendering it.How does it work?
Previously, some main attributes were being defined inside
InputText
component (e.g.onInput
andvalue
) and by doing this, parent components rendering theInputText
had limitations using the same attributes.How to test it?
The component should look the same as before. The main difference is the change of the responsibility to implement input's required attributes to the parent.
Checklist
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#4)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation