Feat: adds tokens to Footer
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatamottam
added
Documentation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-d301101--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit d301101
|
…x-sites/nextjs.store into feat/theming-footer-fsss-376
There was a problem hiding this comment.
Good Job! ✨ ✨
I noticed some discrepancies comparing with https://nextjs.vtex.app/
Is that intentional?
I left some comments along the review, and I'm also in doubt if makes sense to use local tokens in some margin/padding values. So it's up to you hahah
Co-authored-by: Eduardo Formiga <[email protected]>
Co-authored-by: Eduardo Formiga <[email protected]>
victorhmp
requested changes
Jul 8, 2022
victorhmp
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR applies the new Theming structure to
Footer: new scoped tokens linked to global ones.It also updates
Incentivesdoc and add CSS Modules to it.How does it work?
This PR uses local variables to parameterize the
Footerproperties, then connects these scoped tokens to the global ones.As de majority of Footer's styles are grid related, I chose to focus only on what would someone change to make a custom footer.
Tokens list can be visualized in the Storybook.
How to test it?
Footercomponent and its related components should look just as it was before these changes.Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#4)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.Documentation